Skip to content

[DYNAREC] Added BOX64_DYNAREC_DISASM for Zydis disassembly in dynarec dump#4049

Merged
ptitSeb merged 1 commit into
ptitSeb:mainfrom
Mikura-Kyouka:autodump
Jul 20, 2026
Merged

[DYNAREC] Added BOX64_DYNAREC_DISASM for Zydis disassembly in dynarec dump#4049
ptitSeb merged 1 commit into
ptitSeb:mainfrom
Mikura-Kyouka:autodump

Conversation

@Mikura-Kyouka

Copy link
Copy Markdown
Contributor

No description provided.

@ptitSeb

ptitSeb commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Your change would make Zydis to initialize all the time, wich is something we do not want. It should initialize only when needed.

@ksco

ksco commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

wich is something we do not want.

Why?

@ptitSeb

ptitSeb commented Jul 16, 2026

Copy link
Copy Markdown
Owner

wich is something we do not want.

Why?

We don't need to load stuffs we don't use. Why having more memory consumed for nothing?

@ksco

ksco commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Only if you enabled HAVE_TRACE when compiling, which non-devs should not enable.

@ptitSeb

ptitSeb commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Still, I don't want lib loaded if we don't use it. Adding a check of dump or trace enable is easy enough, I don't see why we shouldn't keep the test.

@Mikura-Kyouka

Copy link
Copy Markdown
Contributor Author

My intention is that I think it is not intuitive to use BOX64_TRACE=0-1 to enable Zydis loading. Maybe a new option can be added for control, and the new option will be automatically turned on when BOX64_TRACE is on.

@ptitSeb

ptitSeb commented Jul 16, 2026

Copy link
Copy Markdown
Owner

My intention is that I think it is not intuitive to use BOX64_TRACE=0-1 to enable Zydis loading. Maybe a new option can be added for control, and the new option will be automatically turned on when BOX64_TRACE is on.

I understand, and I aggree but I think there is a need for a env. var. option for that.

Comment thread src/emu/x64run.c Outdated
Comment thread src/include/box64context.h
@Mikura-Kyouka
Mikura-Kyouka force-pushed the autodump branch 2 times, most recently from 7a20d1c to d23daa2 Compare July 20, 2026 11:15
@ptitSeb

ptitSeb commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Ok, it's nice, but it's either missing something, or the title of the is wrong now.

@Mikura-Kyouka Mikura-Kyouka changed the title [DYNAREC] Auto-initialize Zydis for dynarec dump in trace builds [DYNAREC] Added BOX64_DYNAREC_DUMP_ZYDIS for Zydis disassembly in dynarec dump Jul 20, 2026
@Mikura-Kyouka

Copy link
Copy Markdown
Contributor Author

Ok, it's nice, but it's either missing something, or the title of the is wrong now.

Sorry I forgot to change the title. Now it is the same as the commit message.

Comment thread docs/gen/usage.json Outdated
@ksco

ksco commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

You should update the commit message as well as PR title to reflect the name change.

@Mikura-Kyouka Mikura-Kyouka changed the title [DYNAREC] Added BOX64_DYNAREC_DUMP_ZYDIS for Zydis disassembly in dynarec dump [DYNAREC] Added BOX64_DYNAREC_DISASM for Zydis disassembly in dynarec dump Jul 20, 2026
@Mikura-Kyouka

Copy link
Copy Markdown
Contributor Author

You should update the commit message as well as PR title to reflect the name change.

Sorry, I forgot again... Fixed.

Comment thread docs/gen/usage.json Outdated
Comment thread docs/gen/usage.json Outdated
@Mikura-Kyouka

Copy link
Copy Markdown
Contributor Author

Sorry for missing changes again and again...

@ksco
ksco requested a review from ptitSeb July 20, 2026 15:03
@ptitSeb
ptitSeb merged commit 0cec433 into ptitSeb:main Jul 20, 2026
45 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants