[DYNAREC] Added BOX64_DYNAREC_DISASM for Zydis disassembly in dynarec dump#4049
Conversation
|
Your change would make Zydis to initialize all the time, wich is something we do not want. It should initialize only when needed. |
Why? |
We don't need to load stuffs we don't use. Why having more memory consumed for nothing? |
|
Only if you enabled |
|
Still, I don't want lib loaded if we don't use it. Adding a check of dump or trace enable is easy enough, I don't see why we shouldn't keep the test. |
|
My intention is that I think it is not intuitive to use |
I understand, and I aggree but I think there is a need for a env. var. option for that. |
7a20d1c to
d23daa2
Compare
|
Ok, it's nice, but it's either missing something, or the title of the is wrong now. |
Sorry I forgot to change the title. Now it is the same as the commit message. |
|
You should update the commit message as well as PR title to reflect the name change. |
Sorry, I forgot again... Fixed. |
|
Sorry for missing changes again and again... |
No description provided.